fix(shell): preview Unicode truncation uses byte length instead of char length#29288
Open
LifeJiggy wants to merge 1 commit into
Open
fix(shell): preview Unicode truncation uses byte length instead of char length#29288LifeJiggy wants to merge 1 commit into
LifeJiggy wants to merge 1 commit into
Conversation
…ar length The preview function used text.length (UTF-16 code units) to check if output exceeds the metadata limit, but the actual truncation should be based on byte length for correct handling of multi-byte characters (CJK, emoji, etc.). Use Buffer.byteLength for the check and ensure truncated output does not split a multi-byte character.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6 tasks
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29291
Type of change
What does this PR do?
The
preview()function inshell.tsusedtext.length(UTF-16 code units) to check if output exceeds the 30,000-byte metadata limit. Multi-byte characters like CJK (3 bytes each) or emoji (4 bytes) were incorrectly counted. The fix usesBuffer.byteLength()for byte-accurate checking and ensures truncated output doesn't split a multi-byte character.How did you verify your code works?
Screenshots / recordings
N/A
Checklist